lkml.org 
[lkml]   [2011]   [Apr]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] linux/string.h: Introduce streq macro.
    From
    Date
    On Tue, 2011-04-26 at 15:49 -0300, Thiago Farina wrote:
    > This macro is arguably more readable than its variants:
    > - !strcmp(a, b)
    > - strcmp(a, b) == 0
    >

    If this is acceptable, perhaps we should push this for cleanups around
    the kernel.

    > Signed-off-by: Thiago Farina <tfransosi@gmail.com>

    Acked-by: Steven Rostedt <rostedt@goodmis.org>

    > ---
    > include/linux/string.h | 11 +++++++++++
    > 1 files changed, 11 insertions(+), 0 deletions(-)
    >
    > diff --git a/include/linux/string.h b/include/linux/string.h
    > index a716ee2..15b9602 100644
    > --- a/include/linux/string.h
    > +++ b/include/linux/string.h
    > @@ -134,6 +134,17 @@ extern ssize_t memory_read_from_buffer(void *to, size_t count, loff_t *ppos,
    > const void *from, size_t available);
    >
    > /**
    > + * streq - Are two strings equal?
    > + * @a: first string
    > + * @b: second string
    > + *
    > + * Example:
    > + * if (streq(argv[1], "--help"))
    > + * printf("%s\n", "This help");
    > + */
    > +#define streq(a, b) (strcmp((a), (b)) == 0)

    Are the extra parenthesis around the 'a' and 'b' necessary? Anything
    used in streq() would be the same as what is in strcmp(). Actually, this
    may be even better to make it a static inline.

    static inline int streq(const char *a, const char *b)
    {
    return strcmp(a, b) == 0;
    }


    -- Steve

    > +
    > +/**
    > * strstarts - does @str start with @prefix?
    > * @str: string to examine
    > * @prefix: prefix to look for.




    \
     
     \ /
      Last update: 2011-04-26 21:03    [W:0.023 / U:91.408 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site