lkml.org 
[lkml]   [2011]   [Apr]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 1/5] dmaengine: at_hdmac: modify way to use interrupts
On 09:32 Tue 26 Apr     , Koul, Vinod wrote:
> On Fri, 2011-04-22 at 19:41 +0200, Nicolas Ferre wrote:
> > Now we use Buffer Transfer Completed interrupts. If we
> > want a chained buffer completed information, we setup the
> > ATC_IEN bit in CTRLB register in the lli.
> > This is done by set_desc_eol() function and used by
> > memcpy/slave_sg functions.
> >
> > Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> > ---
> > drivers/dma/at_hdmac.c | 4 ++--
> > drivers/dma/at_hdmac_regs.h | 11 ++++++++---
> > 2 files changed, 10 insertions(+), 5 deletions(-)
> >
> >
> Looks like your forgot to run checkpatch
> WARNING: line over 80 characters
> #401: FILE: drivers/dma/at_hdmac_regs.h:106:
> +#define MEM_IF 0 /* specify AHB interface 0 as memory interface */
>
> WARNING: line over 80 characters
> #402: FILE: drivers/dma/at_hdmac_regs.h:107:
> +#define PER_IF 1 /* specify AHB interface 1 as peripheral interface
> */
>
> WARNING: line over 80 characters
> #689: FILE: drivers/dma/at_hdmac.c:899:
> + direction == DMA_TO_DEVICE ? "TO DEVICE" : "FROM DEVICE",
>
> total: 0 errors, 3 warnings, 465 lines checked
>
> While I am okay with 3rd one, you can easily reformat code for first two
> and avoid these two warnings...
It's comments it make it more readable

Best Regards,
J.


\
 
 \ /
  Last update: 2011-04-26 06:53    [from the cache]
©2003-2011 Jasper Spaans