Messages in this thread | | | Date | Tue, 26 Apr 2011 11:19:22 +0800 | Subject | Re: [PATCH] use oom_killer_disabled in all oom pathes | From | Dave Young <> |
| |
On Tue, Apr 26, 2011 at 11:14 AM, KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> wrote: >> On Tue, Apr 26, 2011 at 10:57 AM, KOSAKI Motohiro >> <kosaki.motohiro@jp.fujitsu.com> wrote: >> >> oom_killer_disable should be a global switch, also fit for oom paths >> >> other than __alloc_pages_slowpath >> >> >> >> Here add it to mem_cgroup_handle_oom and pagefault_out_of_memory as well. >> > >> > Can you please explain more? Why should? Now oom_killer_disabled is used >> > only hibernation path. so, Why pagefault and memcg allocation will be happen? >> >> Indeed I'm using it in virtio balloon test, oom killer triggered when >> memory pressure is high. >> >> literally oom_killer_disabled scope should be global, isn't it? > > ok. virtio baloon seems fair usage. if you add new usage of oom_killer_disabled > into the patch description, I'll ack this one.
Thanks, then I will resend the virtio balloon patch along with this.
-- Regards dave
| |