[lkml]   [2011]   [Apr]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[PATCH 128/173] UBIFS: do not read flash unnecessarily review patch.  If anyone has any objections, please let us know.


    From: Artem Bityutskiy <>

    commit 8b229c76765816796eec7ccd428f03bd8de8b525 upstream.

    This fix makes the 'dbg_check_old_index()' function return
    immediately if debugging is disabled, instead of executing
    incorrect 'goto out' which causes UBIFS to:

    1. Allocate memory
    2. Read the flash

    On every commit. OK, we do not commit that often, but it is
    still silly to do unneeded I/O anyway.

    Credits to coverity for spotting this silly issue.

    Signed-off-by: Artem Bityutskiy <>
    Signed-off-by: Greg Kroah-Hartman <>

    fs/ubifs/commit.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/fs/ubifs/commit.c
    +++ b/fs/ubifs/commit.c
    @@ -518,7 +518,7 @@ int dbg_check_old_index(struct ubifs_inf
    size_t sz;

    if (!(ubifs_chk_flags & UBIFS_CHK_OLD_IDX))
    - goto out;
    + return 0;


     \ /
      Last update: 2011-04-25 22:45    [W:0.019 / U:8.912 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site