[lkml]   [2011]   [Apr]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[PATCH 073/173] powerpc/kdump: Use chip->shutdown to disable IRQs review patch.  If anyone has any objections, please let us know.


    From: Anton Blanchard <>

    commit 5d7a87217de48b234b3c8ff8a73059947d822e07 upstream.

    I saw this in a kdump kernel:

    IOMMU table initialized, virtual merging enabled
    Interrupt 155954 (real) is invalid, disabling it.
    Interrupt 155953 (real) is invalid, disabling it.

    ie we took some spurious interrupts. default_machine_crash_shutdown tries
    to disable all interrupt sources but uses chip->disable which maps to
    the default action of:

    static void default_disable(unsigned int irq)

    If we use chip->shutdown, then we actually mask the IRQ:

    static void default_shutdown(unsigned int irq)
    struct irq_desc *desc = irq_to_desc(irq);

    desc->status |= IRQ_MASKED;

    Not sure why we don't implement a ->disable action for xics.c, or why
    default_disable doesn't mask the interrupt.

    Signed-off-by: Anton Blanchard <>
    Signed-off-by: Benjamin Herrenschmidt <>
    Signed-off-by: Kamalesh babulal <>
    Signed-off-by: Greg Kroah-Hartman <>

    arch/powerpc/kernel/crash.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/arch/powerpc/kernel/crash.c
    +++ b/arch/powerpc/kernel/crash.c
    @@ -381,7 +381,7 @@ void default_machine_crash_shutdown(stru

    if (!(desc->status & IRQ_DISABLED))
    - desc->chip->disable(i);
    + desc->chip->shutdown(i);


     \ /
      Last update: 2011-04-25 22:43    [W:0.019 / U:110.052 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site