lkml.org 
[lkml]   [2011]   [Apr]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 3/3] signal: do_sigtimedwait() needs retarget_shared_pending()
    On 04/25, Tejun Heo wrote:
    >
    > On Mon, Apr 25, 2011 at 06:01:15PM +0200, Oleg Nesterov wrote:
    > >
    > > Again, I can rename... Cough, but in this case please simply suggest
    > > another name. set_tsk_blocked_locked?
    >
    > Oooh, blocked_locked, didn't see that one coming. Maybe
    > set_tsk_sigmask()

    but it is not _tsk, it is specially named set_current_blocked() to
    show that it only applies to current. And _blocked clearly shows what
    it should change, like set_current_state().

    OK, this is purely cosmetic, and __set_tsk_blocked() is static and has
    a single caller. Can we keep this naming for now? it would be trivial
    to rename later.

    Oleg.



    \
     
     \ /
      Last update: 2011-04-25 19:11    [W:0.020 / U:58.760 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site