Messages in this thread | | | Date | Fri, 22 Apr 2011 13:31:18 +0100 | From | Matt Fleming <> | Subject | Re: [PATCH v2 4/7] signal: sigprocmask: narrow the scope of ->siglock |
| |
On Mon, 18 Apr 2011 15:45:38 +0200 Oleg Nesterov <oleg@redhat.com> wrote:
> No functional changes, preparation to simplify the review of the next change. > > 1. We can read current->block lockless, nobody else can ever change this mask. > > 2. Calculate the resulting sigset_t outside of ->siglock into the temporary > variable, then take ->siglock and change ->blocked. > > Also, kill the stale comment about BKL. > > Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Thanks for that updated comment about not being able to change ->blocked from irq context!
Reviewed-by: Matt Fleming <matt.fleming@linux.intel.com>
| |