lkml.org 
[lkml]   [2011]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] tg3: Convert u32 flag,flg2,flg3 uses to bitmap
From
Date

On Wed, 2011-04-20 at 23:39 -0700, Joe Perches wrote:
> @@ -4622,7 +4611,7 @@ static void tg3_tx_recover(struct tg3 *tp)
> "and include system chipset information.\n");
>
> spin_lock(&tp->lock);
> - tp->tg3_flags |= TG3_FLAG_TX_RECOVERY_PENDING;
> + tg3_flag_set(tp, TX_RECOVERY_PENDING);
> spin_unlock(&tp->lock);
> }
>

By using set_bit() now, we can eliminate the spin_lock() here. This
flag is checked much later when tg3_reset_task() is scheduled to run in
workqueue, so no memory barrier is needed either.

Thanks.




\
 
 \ /
  Last update: 2011-04-21 19:25    [W:0.899 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site