lkml.org 
[lkml]   [2011]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] x86, MCE: Do not taint when handling correctable errors
On Thu, Apr 21, 2011 at 05:58:48AM -0400, Ingo Molnar wrote:
> Ok, indeed. Also, in the future, if you take patches from others please also
> credit them in the changelog. Something like this would have been good in the
> current case:
>
> Also, this patch includes a change from Nagananda Chumbalkar as well, which
> drops tainting in the therma throttling code for a similar reason: crossing a
> thermal threshold does not mean corruption.
>
> Nagananda's Acked-by is there so there's at least partial credit - but we
> generally try to aim for at least 100% credit where credit is due :-)

Absolutely, and in the light of recent events :) I'm still not sure how
to do that though in a straight-forward manner so that it is visible at
a first glance. Sure, adding freeform text to the commit message is one
way. Using a SOB chain might work too - even the Acked-by tag - but all
those have another main purpose and are being repurposed for annotating
the fact that a patch is the result of more than one author's thought
process.

IOW, in case I'm not missing anything, we don't really have a way to
denote a multiple authorship, correct? And we should...

Thanks.

--
Regards/Gruss,
Boris.

Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632


\
 
 \ /
  Last update: 2011-04-21 12:09    [W:0.039 / U:0.800 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site