lkml.org 
[lkml]   [2011]   [Apr]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3] mm: make expand_downwards symmetrical to expand_upwards
On Wed, 20 Apr 2011, Christoph Lameter wrote:

> There is barely any testing going on at all of this since we have had this
> issue for more than 5 years and have not noticed it. The absence of bug
> reports therefore proves nothing. Code inspection of the VM shows
> that this is an issue that arises in multiple subsystems and that we have
> VM_BUG_ONs in the page allocator that should trigger for these situations.
>
> Usage of DISCONTIGMEM and !NUMA is not safe and should be flagged as such.
>

We don't actually have any bug reports in front of us that show anything
else in the VM other than slub has issues with this configuration, so
marking them as broken is probably premature. The parisc config that
triggered this debugging enables CONFIG_SLAB by default, so it probably
has gone unnoticed just because nobody other than James has actually tried
it on hppa64.

Let's see if KOSAKI-san's fixes to Kconfig (even though I'd prefer the
simpler and implicit "config NUMA def_bool ARCH_DISCONTIGMEM_ENABLE" over
his config NUMA) and my fix to parisc to set the bit in N_NORMAL_MEMORY
so that CONFIG_SLUB initializes kmem_cache_node correctly works and then
address issues in the core VM as they arise. Presumably someone has been
running DISCONTIGMEM on hppa64 in the past five years without issues with
defconfig, so the issue here may just be slub.


\
 
 \ /
  Last update: 2011-04-20 23:45    [W:0.238 / U:0.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site