lkml.org 
[lkml]   [2011]   [Apr]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 16/18] 2.6.40: x86 idle APM: remove deprecated apm_cpu_idle()
On Sat, 02 Apr 2011 02:22:58 -0400
Len Brown <lenb@kernel.org> wrote:

> From: Len Brown <len.brown@intel.com>
>
> There is some doubt whether the APM idle feature
> to call into the BIOS from the idle loop is reliable.
> Certainly it was known to fail on some machines,

And it was known to work on lots - a point that despite repeated
reminding you seem keen to ignore.

The fundamental problem I have with this patch set is this

You've provided no architectural overall justification for all this
effort. What is the big picture around your crusade here ? What is the
grand plan ?

> but more importantly, APM machines have not shipped
> for a decade and so finding machines to test the code
> is problematic.

So don't test it - if it's wrong someone will let you know, believe me 8)

And 2.6.40 is far too soon - it takes about a year for stuff to rattle
through to leading edge distro users in bulk

Alan



\
 
 \ /
  Last update: 2011-04-02 13:43    [W:0.184 / U:8.012 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site