lkml.org 
[lkml]   [2011]   [Apr]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH V2 3/7] dmaengine/dw_dmac: call dwc_descriptor_complete from dwc_control with lock held
    Date
    dwc_descriptor_complete must always be called with channel lock held. This patch
    moves unlock code, in dwc_control(), untill after dwc_descriptor_complete is
    called.

    Signed-off-by: Viresh Kumar <viresh.kumar@st.com>
    ---
    drivers/dma/dw_dmac.c | 4 ++--
    1 files changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c
    index 66d7f1b..c211460 100644
    --- a/drivers/dma/dw_dmac.c
    +++ b/drivers/dma/dw_dmac.c
    @@ -825,12 +825,12 @@ static int dwc_control(struct dma_chan *chan, enum dma_ctrl_cmd cmd,
    list_splice_init(&dwc->queue, &list);
    list_splice_init(&dwc->active_list, &list);

    - spin_unlock_irqrestore(&dwc->lock, dwc->lflags);
    -
    /* Flush all pending and queued descriptors */
    list_for_each_entry_safe(desc, _desc, &list, desc_node)
    dwc_descriptor_complete(dwc, desc);

    + spin_unlock_irqrestore(&dwc->lock, dwc->lflags);
    +
    return 0;
    }

    --
    1.7.2.2


    \
     
     \ /
      Last update: 2011-04-19 10:35    [W:0.020 / U:31.904 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site