lkml.org 
[lkml]   [2011]   [Apr]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH V2 2/7] dmaengine/dw_dmac: Enable resubmission from callback routine.
    Date
    Resubmission of new transfer must be allowed from callbacks. For this release
    lock before calling callback routine and enable them again.

    Signed-off-by: Viresh Kumar <viresh.kumar@st.com>
    ---
    drivers/dma/dw_dmac.c | 10 ++++------
    1 files changed, 4 insertions(+), 6 deletions(-)

    diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c
    index c4040dd..66d7f1b 100644
    --- a/drivers/dma/dw_dmac.c
    +++ b/drivers/dma/dw_dmac.c
    @@ -197,8 +197,8 @@ static void dwc_dostart(struct dw_dma_chan *dwc, struct dw_desc *first)
    static void
    dwc_descriptor_complete(struct dw_dma_chan *dwc, struct dw_desc *desc)
    {
    - dma_async_tx_callback callback;
    - void *param;
    + dma_async_tx_callback callback = NULL;
    + void *param = NULL;
    struct dma_async_tx_descriptor *txd = &desc->txd;
    struct dw_desc *child;

    @@ -238,12 +238,10 @@ dwc_descriptor_complete(struct dw_dma_chan *dwc, struct dw_desc *desc)
    }
    }

    - /*
    - * The API requires that no submissions are done from a
    - * callback, so we don't need to drop the lock here
    - */
    + spin_unlock_irqrestore(&dwc->lock, dw->flags);
    if (callback)
    callback(param);
    + spin_lock_irqsave(&dwc->lock, dw->flags);
    }

    static void dwc_complete_all(struct dw_dma *dw, struct dw_dma_chan *dwc)
    --
    1.7.2.2


    \
     
     \ /
      Last update: 2011-04-19 10:35    [W:0.024 / U:0.188 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site