lkml.org 
[lkml]   [2011]   [Apr]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3] uio/pdrv_genirq: Add OF support
Wolfram Sang wrote:
> Hi,
>
>> For example with "uio" compatible string:
>> static const struct of_device_id __devinitconst uio_of_genirq_match[] = {
>> { .compatible = "uio", },
>> { /* empty for now */ },
>> };
>
> Please use a proper example with "vendor,device".
> (And after that it won't be empty anymore)
>
>> + /* Multiple IRQs are not supported */
>> + irq = platform_get_irq(pdev, 0);
>> + if (irq < 0) {
>> + uioinfo->irq = UIO_IRQ_NONE;
>> + dev_info(&pdev->dev, "no IRQ found\n");
>> + } else {
>> + uioinfo->irq = irq;
>> + dev_info(&pdev->dev, "irq %d\n", (u32)uioinfo->irq);
>> + }
>
> Come to think of it, the driver so far does not print any dev_info messages,
> only err and warn. So, I'd think these messages should go, too, but this is up
> to Hans.

I used that because I wanted to see more information about UIO in bootlog. If
you and Hans want to remove it, I will do it.

Thanks,
Michal



--
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian


\
 
 \ /
  Last update: 2011-04-19 10:19    [from the cache]
©2003-2011 Jasper Spaans