lkml.org 
[lkml]   [2011]   [Apr]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 2.6.39-rc1-tip 15/26] 15: uprobes: Handing int3 and singlestep exception.
From
Date
On Fri, 2011-04-01 at 20:05 +0530, Srikar Dronamraju wrote:
> + probept = uprobes_get_bkpt_addr(regs);
> + down_read(&mm->mmap_sem);
> + for (vma = mm->mmap; vma; vma = vma->vm_next) {
> + if (!valid_vma(vma))
> + continue;
> + if (probept < vma->vm_start || probept > vma->vm_end)
> + continue;
> + u = find_uprobe(vma->vm_file->f_mapping->host,
> + probept - vma->vm_start);
> + break;
> + }

Why the linear vma walk? Surely the find_vma() suffices since there can
only be one vma that matches a particular vaddr.

> + up_read(&mm->mmap_sem);


\
 
 \ /
  Last update: 2011-04-19 15:43    [W:0.199 / U:2.428 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site