Messages in this thread | | | From | Haojian Zhuang <> | Date | Mon, 18 Apr 2011 19:45:06 -0700 | Subject | RE: [PATCH 14/14] regulator: 88pm8607: avoid to use constraint name in driver |
| |
>-----Original Message----- >From: Mark Brown [mailto:broonie@opensource.wolfsonmicro.com] >Sent: 2011年4月19日 12:03 AM >To: Haojian Zhuang >Cc: Haojian Zhuang; sameo@linux.intel.com; linux-kernel@vger.kernel.org; >dmitry.torokhov@gmail.com; a.zummo@towertech.it; johnpol@2ka.mipt.ru; >cbou@mail.ru; dwmw2@infradead.org; lrg@slimlogic.co.uk >Subject: Re: [PATCH 14/14] regulator: 88pm8607: avoid to use constraint >name in driver > >On Mon, Apr 18, 2011 at 11:38:00PM +0800, Haojian Zhuang wrote: >> On Mon, Apr 18, 2011 at 10:30 PM, Mark Brown > >> > Why not just use #defines in the header? It'd be less error prone >if >> > nothing else. > >> I don't understand this. desc.name is assigned in regulator driver. >> pdata->driver_data is assigned in platform driver. I need to use same >> name to link them together. > >I assume that by "platform driver" you mean the machine driver for the >system? What I'm saying is that instead of using a string to match it'd >be more normal to use an enum in the driver header, that way if someone >typos the string or something then there will be a build failure whereas >with strings like this there will only be a runtime failure. > It's nearly same whatever it's string or index number. In machine driver, it's more convenient on using string. Otherwise, I still need to create a new integer array to store index since I transfer them into regulator data by driver_data parameter in regulator_init_data.
>Part of the problem here is that your changelogs aren't really saying >why you're making these changes... Yes, the changelog is too simple.
| |