Messages in this thread | | | From | KOSAKI Motohiro <> | Subject | Re: [PATCH v2] mempolicy: reduce references to the current | Date | Tue, 19 Apr 2011 09:34:14 +0900 (JST) |
| |
> Remove duplicated reference to the 'current' task using a local > variable. Since refering the current can be a burden, it'd better > cache the reference, IMHO. At least this saves some bytes on x86_64. > > $ size mempolicy-{old,new}.o > text data bss dec hex filename > 25203 2448 9176 36827 8fdb mempolicy-old.o > 25136 2448 9184 36768 8fa0 mempolicy-new.o > > Signed-off-by: Namhyung Kim <namhyung@gmail.com>
But, dense stack usage is also performance good thing. Therefore your patch benefit is not obvious. I have two request.
1) Please don't increase mess into no hot path. It's no worth. 2) Please mesure performance your box instead size command.
thanks.
| |