Messages in this thread | | | From | Kay Sievers <> | Date | Tue, 19 Apr 2011 01:14:57 +0200 | Subject | Re: Linux 2.6.39-rc3 |
| |
On Tue, Apr 19, 2011 at 01:02, Dave Jones <davej@redhat.com> wrote: > On Tue, Apr 19, 2011 at 12:57:27AM +0200, Kay Sievers wrote: > > > > uuid:<value> is the option field as per > > > Documentation/filesystem/proc.txt. There was an error in libmount > > > parsing which got fixed upstream recently > > > > Just a simple question about this approach in general? A filesystem > > UUID can be changed on disk at any time (tune2fs -U ...). > > > > Your code looks like you copy the bytes to the in-kernel superblock > > structure without noticing any later changes on disk? How is that > > supposed to work? > > I thought tune2fs on a mounted filesystem was always a > "you get to keep both pieces if it breaks" situation.
No idea, it works fine that way since forever. :)
$ cat /proc/self/mountinfo | grep sda1 21 1 8:1 / / rw,relatime - ext4 /dev/sda1 rw, ...
$ blkid /dev/sda1 /dev/sda1: LABEL="root" UUID="0e4974cc-6a11-11e0-8d7b-002186a23ce5" TYPE="ext4"
$ tune2fs -U time /dev/sda1 tune2fs 1.41.14 (22-Dec-2010)
$ blkid /dev/sda1 /dev/sda1: LABEL="root" UUID="26be6e7c-6a11-11e0-ad62-002186a23ce5" TYPE="ext4"
I don't think that approach makes any sense without doing a call into the filesystem, and such calls have no place in mountinfo.
Kay -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |