Messages in this thread | | | Date | Mon, 18 Apr 2011 13:56:37 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH v2] mm: make expand_downwards symmetrical to expand_upwards |
| |
On Mon, 18 Apr 2011 12:01:31 +0200 Michal Hocko <mhocko@suse.cz> wrote:
> Currently we have expand_upwards exported while expand_downwards is > accessible only via expand_stack or expand_stack_downwards. > > check_stack_guard_page is a nice example of the asymmetry. It uses > expand_stack for VM_GROWSDOWN while expand_upwards is called for > VM_GROWSUP case. > > Let's clean this up by exporting both functions and make those name > consistent. Let's use expand_stack_{upwards,downwards} so that we are > explicit about stack manipulation in the name. expand_stack_downwards > has to be defined for both CONFIG_STACK_GROWS{UP,DOWN} because > get_arg_page calls the downwards version in the early process > initialization phase for growsup configuration.
Has this patch been tested on any stack-grows-upwards architecture?
| |