lkml.org 
[lkml]   [2011]   [Apr]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH] OMAP: iommu flush page table entries from L1 and L2 cache
    Date
    On Friday 15 April 2011, Russell King - ARM Linux wrote:
    > On Thu, Apr 14, 2011 at 04:52:48PM -0500, Fernando Guzman Lugo wrote:
    > > From: Ramesh Gupta <grgupta@ti.com>
    > >
    > > This patch is to flush the iommu page table entries from L1 and L2
    > > caches using dma_map_single. This also simplifies the implementation
    > > by removing the functions flush_iopgd_range/flush_iopte_range.
    >
    > No. This usage is just wrong. If you're going to use the DMA API then
    > unmap it, otherwise the DMA API debugging will go awol.


    It's also completely upside-down: The iommu support should provide interfaces
    using the dma-mapping API, not use that API to provide a machine specific
    version of the generic interface.

    As far as I can tell, nothing actually uses these drivers, maybe we should just
    remove them before we get any code in the mainline kernel that depends on it.

    Arnd


    \
     
     \ /
      Last update: 2011-04-18 09:33    [W:0.022 / U:0.180 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site