Messages in this thread | | | Date | Mon, 18 Apr 2011 15:28:56 +0100 | From | Mark Brown <> | Subject | Re: [PATCH 13/14] regulator: check name in initialization of max8925 |
| |
On Mon, Apr 18, 2011 at 10:04:10PM +0800, Haojian Zhuang wrote: > Check name in initialization of max8925 regulator driver.
What name are we checking and why do we need to check it? I've no idea what the patch is supposed to do which makes it hard to review.
> +++ b/drivers/regulator/max8925-regulator.c > @@ -174,7 +174,7 @@ static struct regulator_ops max8925_regulator_ldo_ops = { > #define MAX8925_SDV(_id, min, max, step) \ > { \ > .desc = { \ > - .name = "SDV" #_id, \ > + .name = "SD" #_id, \
The above isn't obviously correct - it changes the name that's assigned from matching the macro used to something different.
| |