lkml.org 
[lkml]   [2011]   [Apr]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRE: [PATCH 12/13] regulator: check name in initialization of max8925


    >-----Original Message-----
    >From: Mark Brown [mailto:broonie@opensource.wolfsonmicro.com]
    >Sent: 2011年4月17日 2:02 AM
    >To: Haojian Zhuang
    >Cc: sameo@linux.intel.com; haojian.zhuang@gmail.com; linux-
    >kernel@vger.kernel.org; Liam Girdwood
    >Subject: Re: [PATCH 12/13] regulator: check name in initialization of
    >max8925
    >
    >On Wed, Apr 13, 2011 at 10:51:03PM +0800, Haojian Zhuang wrote:
    >> Check name in initialization of max8925 regulator driver.
    >
    >> + if (!strcmp(ri->desc.name, pdata->constraints.name))
    >> + break;
    >
    >This isn't a good change - the whole point of the name in the
    >constraints is that it allows the user to assign an arbatrary string
    >which is useful for the board. The driver should never be looking
    >inside the constraints at all, the core will apply the constraints for
    >you.

    I'll move the name of regulator into regulator_init_data->driver_data.

    Thanks
    Haojian
    \
     
     \ /
      Last update: 2011-04-18 15:55    [W:0.031 / U:118.848 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site