Messages in this thread Patch in this message | | | Date | Mon, 18 Apr 2011 15:46:41 +0200 | From | Oleg Nesterov <> | Subject | [PATCH v2 7/7] x86: signal: sys_rt_sigreturn() should use set_current_blocked() |
| |
Normally sys_rt_sigreturn() restores the old current->blocked which was changed by handle_signal(), and unblocking is always fine.
But the debugger or application itself can change frame->uc_sigmask and thus we need set_current_blocked()->retarget_shared_pending().
Signed-off-by: Oleg Nesterov <oleg@redhat.com> ---
arch/x86/kernel/signal.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
--- sigprocmask/arch/x86/kernel/signal.c~7_sigreturn 2011-04-17 23:07:14.000000000 +0200 +++ sigprocmask/arch/x86/kernel/signal.c 2011-04-17 23:19:13.000000000 +0200 @@ -601,10 +601,7 @@ long sys_rt_sigreturn(struct pt_regs *re goto badframe; sigdelsetmask(&set, ~_BLOCKABLE); - spin_lock_irq(¤t->sighand->siglock); - current->blocked = set; - recalc_sigpending(); - spin_unlock_irq(¤t->sighand->siglock); + set_current_blocked(&set); if (restore_sigcontext(regs, &frame->uc.uc_mcontext, &ax)) goto badframe;
| |