lkml.org 
[lkml]   [2011]   [Apr]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch v2 2/4] percpu_counter: delete dead code
I'll take care of merging this patch via the ext4 tree.

- Ted

On Wed, Apr 13, 2011 at 03:57:17PM +0800, shaohua.li@intel.com wrote:
> percpu_counter_sum_positive never returns negative.
>
> Signed-off-by: Shaohua Li <shaohua.li@intel.com>
>
> ---
> fs/ext4/balloc.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> Index: linux/fs/ext4/balloc.c
> ===================================================================
> --- linux.orig/fs/ext4/balloc.c 2011-04-12 16:22:59.000000000 +0800
> +++ linux/fs/ext4/balloc.c 2011-04-13 13:23:01.000000000 +0800
> @@ -507,11 +507,6 @@ static int ext4_has_free_blocks(struct e
> EXT4_FREEBLOCKS_WATERMARK) {
> free_blocks = percpu_counter_sum_positive(fbc);
> dirty_blocks = percpu_counter_sum_positive(dbc);
> - if (dirty_blocks < 0) {
> - printk(KERN_CRIT "Dirty block accounting "
> - "went wrong %lld\n",
> - (long long)dirty_blocks);
> - }
> }
> /* Check whether we have space after
> * accounting for current dirty blocks & root reserved blocks.
>
>


\
 
 \ /
  Last update: 2011-04-18 02:15    [from the cache]
©2003-2011 Jasper Spaans