lkml.org 
[lkml]   [2011]   [Apr]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 3/3] Btrfs: fix FS_IOC_SETFLAGS ioctl
    Steps to reproduce the bug:

    - Call FS_IOC_SETLFAGS ioctl with flags=FS_COMPR_FL
    - Call FS_IOC_SETFLAGS ioctl with flags=0
    - Call FS_IOC_GETFLAGS ioctl, and you'll see FS_COMPR_FL is still set!

    Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
    ---
    fs/btrfs/ioctl.c | 2 ++
    1 files changed, 2 insertions(+), 0 deletions(-)

    diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c
    index aeabf6b..3e7031d 100644
    --- a/fs/btrfs/ioctl.c
    +++ b/fs/btrfs/ioctl.c
    @@ -238,6 +238,8 @@ static int btrfs_ioctl_setflags(struct file *file, void __user *arg)
    } else if (flags & FS_COMPR_FL) {
    ip->flags |= BTRFS_INODE_COMPRESS;
    ip->flags &= ~BTRFS_INODE_NOCOMPRESS;
    + } else {
    + ip->flags &= ~(BTRFS_INODE_COMPRESS | BTRFS_INODE_NOCOMPRESS);
    }

    trans = btrfs_join_transaction(root, 1);
    --
    1.7.3.1

    \
     
     \ /
      Last update: 2011-04-15 05:03    [W:0.023 / U:59.940 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site