Messages in this thread | | | Date | Thu, 14 Apr 2011 22:15:46 +0200 | From | Oleg Nesterov <> | Subject | Re: [PATCH 6/6] x86: signal: sys_rt_sigreturn() should use sigprocmask() |
| |
On 04/12, Matt Fleming wrote: > > On Mon, 11 Apr 2011 19:22:29 +0200 > Oleg Nesterov <oleg@redhat.com> wrote: > > > Normally sys_rt_sigreturn() restores the old current->blocked which was > > changed by handle_signal(), and unblocking is always fine. > > > > But the debugger or application itself can change frame->uc_sigmask and > > thus we need sigprocmask()->retarget_shared_pending(). > > > > Signed-off-by: Oleg Nesterov <oleg@redhat.com> > > Reviewed-by: Matt Fleming <matt.fleming@linux.intel.com>
Thanks Matt.
> I'm just curious, have you actually seen this bug?
No, never.
But recently Nikita reported the problem which _might_ be explained by this. see http://marc.info/?t=129732355500007 . Although it is quite possible there is something else.
Oleg.
| |