Messages in this thread | | | Date | Thu, 14 Apr 2011 18:08:48 +0200 | From | Uwe Kleine-König <> | Subject | Re: [PATCH 0/2] Common struct clk implementation, v14 |
| |
On Thu, Apr 14, 2011 at 11:32:00AM +0100, Russell King - ARM Linux wrote: > On Thu, Apr 14, 2011 at 08:25:05PM +1000, Benjamin Herrenschmidt wrote: > > On Thu, 2011-04-14 at 11:00 +0100, Russell King - ARM Linux wrote: > > > > > > I will take it, but at the moment I'm rather unhappy about the response > > > from the community to Linus' complaint. > > > > > > If existing platform maintainers can show that moving over to this will > > > result in a net reduction of code under arch/arm, then that will be good. > > > What I don't want to see at the moment is arch/arm increasing in size as > > > a result of any change. We desperately need to see a reduction for the > > > next merge window. > > > > It's a chicken and egg... platform maintainers wait for you to take it > > and you wait for them to take it :-) > > > > It seems to me that this fits well into the category of "better common > > abstractions" that was discussed in the thread initiated by Linus as one > > of the ways to improve on the "clutter"... > > That depends - sometimes creating generic stuff results in a net increase > in the overall size, and that's something that Linus also complained about. > > According to linux-next, where we are at the moment with arch/arm is a > net increase of 6000 lines since the close of the last merge window, > and arch/arm is responsible for almost 75% of arch/ changes. It looks > very much like the same situation which Linus complained about. Well, looking at the output of
git diff --dirstat=3 linus/master...next/master -- arch
(with linus/master == 85f2e689a and next/master == 9e06a6ea7) I think the main culprit is 12dc7eff5 that moved arch/arm/mach-mx3 to arch/arm/mach-imx. (75 files changed, 9783 insertions(+), 9731 deletions(-)) That's a part of the effort to consolidate the i.MX platforms and allow to compile more SoCs in a single image.
That commit accounts for more than the half of the (loc) changes in arch/arm.
OK, this doesn't discuss away the 6000 added lines, but at least the percentage thingy. And I think when you point out this commit Linus will be much quiter when replying to your pull request.
Best regards Uwe
-- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |