[lkml]   [2011]   [Apr]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH -v3] x86, MCE: Drop the default decoding notifier
On Thu, Apr 14, 2011 at 11:04:43AM -0400, Prarit Bhargava wrote:
> On 04/14/2011 11:00 AM, Borislav Petkov wrote:
> > On Wed, Apr 13, 2011 at 01:37:05PM -0400, Borislav Petkov wrote:
> >
> >> In the worst case, we will report 32 CEs before panicking. For that case
> >> we either do printk_once as Tony suggested or we ratelimit it. I'll
> >> update the patch.
> >>
> > Ok, how about the following, I ratelimit the printk to the default of 10
> > messages per 5 seconds. I've also got the hardware MCE injection patches
> > ready and will do some testing with them.
> >
> See my previous email ;) I think just putting in a printk_once after
> the CE call to print_mce() in mce_panic() might be better? At least
> that way we get the --ascii message for *EVERY* UC which IMO would be
> nice...

Are you sure? printk_once() is, as its name says, a one-time thing and
it is implemented that way - a static bool counter which is once set and
that's it. I.e., the "--ascii" message will be printed only once for the
system's lifetime.

The ratelimit-ed thing dumps it a strict number of times. In the end,
I don't have a strong opinion on how many times we issue it - I'm fine
with it either way.

Maybe some other opinions. Tony?


Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632

 \ /
  Last update: 2011-04-14 17:19    [W:0.060 / U:4.360 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site