lkml.org 
[lkml]   [2011]   [Apr]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2/2] sched: next buddy hint on sleep and preempt path -v2
From
Date
On Wed, 2011-04-13 at 18:21 -0700, Venkatesh Pallipadi wrote:
> ---
> kernel/sched_fair.c | 26 +++++++++++++++++++++++---
> 1 files changed, 23 insertions(+), 3 deletions(-)
>
> diff --git a/kernel/sched_fair.c b/kernel/sched_fair.c
> index d3513b7..8828a7e 100644
> --- a/kernel/sched_fair.c
> +++ b/kernel/sched_fair.c
> @@ -1340,6 +1340,8 @@ enqueue_task_fair(struct rq *rq, struct task_struct *p, int flags)
> hrtick_update(rq);
> }
>
> +static void set_next_buddy(struct sched_entity *se);
> +
> /*
> * The dequeue_task method is called before nr_running is
> * decreased. We remove the task from the rbtree and
> @@ -1349,14 +1351,22 @@ static void dequeue_task_fair(struct rq *rq, struct task_struct *p, int flags)
> {
> struct cfs_rq *cfs_rq;
> struct sched_entity *se = &p->se;
> + int task_sleep = flags & DEQUEUE_SLEEP;
>
> for_each_sched_entity(se) {
> cfs_rq = cfs_rq_of(se);
> dequeue_entity(cfs_rq, se, flags);
>
> /* Don't dequeue parent if it has other entities besides us */
> - if (cfs_rq->load.weight)
> + if (cfs_rq->load.weight) {
> + /*
> + * Bias pick_next to pick a task from this cfs_rq, as
> + * p is sleeping when it is within its sched_slice.
> + */
> + if (task_sleep && se->parent)
> + set_next_buddy(se->parent);
> break;
> + }
> flags |= DEQUEUE_SLEEP;
> }
>

You made my compiler sad:

In file included from /home/root/src/linux-2.6/kernel/sched.c:2006:
/home/root/src/linux-2.6/kernel/sched_fair.c: In function ‘dequeue_task_fair’:
/home/root/src/linux-2.6/kernel/sched_fair.c:1370: error: ‘struct sched_entity’ has no member named ‘parent’
/home/root/src/linux-2.6/kernel/sched_fair.c:1371: error: ‘struct sched_entity’ has no member named ‘parent’


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2011-04-14 12:49    [W:0.062 / U:81.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site