lkml.org 
[lkml]   [2011]   [Apr]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCHv2] usb: gadget: storage_common: use kstrto*()
On Thu, Apr 14, 2011 at 02:40:39AM +0200, Michal Nazarewicz wrote:
> This commit replaces the usage of strict_strtoul() (which
> became deprecated after commit 33ee3b2e) with kstrtouint().
>
> Signed-off-by: Michal Nazarewicz <mina86@mina86.com>
> ---
> drivers/usb/gadget/storage_common.c | 18 +++++++++++-------
> 1 files changed, 11 insertions(+), 7 deletions(-)
>
> > @@ -711,10 +711,11 @@ static ssize_t fsg_store_ro(struct device *dev, struct device_attribute *attr,
> > ssize_t rc = count;
> > struct fsg_lun *curlun = fsg_lun_from_dev(dev);
> > struct rw_semaphore *filesem = dev_get_drvdata(dev);
> > - unsigned long ro;
> > + unsigned ro;
> >
> > - if (strict_strtoul(buf, 2, &ro))
> > - return -EINVAL;
> > + rc = kstrtouint(buf, 2, &ro);
> > + if (rc)
> > + return rc;
> >
>
> Sorry, I've just noticed this zeroes the rc so that the function returns
> invalid read length. Attached patch has the following delta included:

Ugh, I applied the first one already :(

Care to send a follow-on patch that fixes this properly?

thanks,

greg k-h


\
 
 \ /
  Last update: 2011-04-14 04:27    [W:0.052 / U:0.488 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site