lkml.org 
[lkml]   [2011]   [Apr]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: Re-send (What else needs to be done to the sep driver (staging/sep))
From
Date
On Wed, 2011-04-13 at 15:23 -0700, Greg KH wrote:
> Ick, no, never use your own macros, just use the "real" things like is
> done in this driver. If it's a pain to get to that pointer, then use a
> temporary variable in the code and then use it.
>
> Otherwise, no, I don't like this patch at all, sorry.

I think you're simply incorrect here.

There are lots of other uses like netdev_<foo>
where <foo>_<level> takes a particular pointer type.

This is a structure that contains a pointer to
another structure than contains a struct device.

You might also look at the macros the USB subsystem
uses for message logging.

Hey, aren't you the USB maintainer?



\
 
 \ /
  Last update: 2011-04-14 00:33    [W:0.033 / U:0.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site