Messages in this thread | | | Date | Wed, 13 Apr 2011 23:47:51 +0200 | From | Jan Kara <> | Subject | Re: [PATCH 1/4] writeback: add bdi_dirty_limit() kernel-doc |
| |
On Wed 13-04-11 16:59:38, Wu Fengguang wrote: > Clarify the bdi_dirty_limit() comment. > > Signed-off-by: Wu Fengguang <fengguang.wu@intel.com> Looks fine.
Acked-by: Jan Kara <jack@suse.cz>
Honza > --- > mm/page-writeback.c | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > --- linux-next.orig/mm/page-writeback.c 2011-03-03 14:38:12.000000000 +0800 > +++ linux-next/mm/page-writeback.c 2011-03-03 14:40:52.000000000 +0800 > @@ -437,10 +437,17 @@ void global_dirty_limits(unsigned long * > *pdirty = dirty; > } > > -/* > +/** > * bdi_dirty_limit - @bdi's share of dirty throttling threshold > + * @bdi: the backing_dev_info to query > + * @dirty: global dirty limit in pages > + * > + * Returns @bdi's dirty limit in pages. The term "dirty" in the context of > + * dirty balancing includes all PG_dirty, PG_writeback and NFS unstable pages. > + * And the "limit" in the name is not seriously taken as hard limit in > + * balance_dirty_pages(). > * > - * Allocate high/low dirty limits to fast/slow devices, in order to prevent > + * It allocates high/low dirty limits to fast/slow devices, in order to prevent > * - starving fast devices > * - piling up dirty pages (that will take long time to sync) on slow devices > * > > -- Jan Kara <jack@suse.cz> SUSE Labs, CR
| |