Messages in this thread | | | Date | Wed, 13 Apr 2011 10:32:49 -0700 | From | Mark Brown <> | Subject | Re: [PATCH 2/5] ASoC: Call snd_soc_new_widgets() after registering cards DAPM widgets |
| |
On Wed, Apr 13, 2011 at 02:32:35PM +0200, Lars-Peter Clausen wrote:
> But snd_soc_dapm_new_widgets also calls dapm_power_widgets which operates on > the passed dapm_context, will it be without any effect on the DAPM context, > when it is called on a newly allocated context?
Yup.
> Otherwise I would say call snd_soc_dapm_new_widgets once for the cards > dapm_context and snd_soc_dapm_sync for each codec context.
There's no point in repeatedly syncing - it may cause audible issues if we power things off due to incomplete information. If the sync isn't propagating over the entire system we should fix that.
| |