lkml.org 
[lkml]   [2011]   [Apr]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -v2] x86, MCE: Drop default decoding notifier

> @@ -239,7 +227,9 @@ static void print_mce(struct mce *m)
> * Print out human-readable details about the MCE error,
> * (if the CPU has an implementation for that)
> */
> - atomic_notifier_call_chain(&x86_mce_decoder_chain, 0, m);
> + ret = atomic_notifier_call_chain(&x86_mce_decoder_chain, 0, m);
> + if (ret != NOTIFY_STOP)
> + pr_emerg(HW_ERR "Run the above through 'mcelog --ascii' to decode.\n");
> }
>

Borislav,

I still think you need the check for UC here. When an UC occurs and
mce_panic() is called the output will include:

[Hardware Error]: Run the above through 'mcelog --ascii' to decode.

potentially many, many times. The problem still is that there is no
output to decode (in the default case).

P.


\
 
 \ /
  Last update: 2011-04-13 19:03    [W:0.052 / U:6.872 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site