lkml.org 
[lkml]   [2011]   [Apr]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86: Clean up mwait_play_dead
On 04/13/2011 09:11 AM, Frank Arnold wrote:
> From: Frank Arnold <frank.arnold@amd.com>
>
> Commit 93789b32dbf355e70f18b17a82e8661677a7f7fb introduced
> cpuinfo_x86 *c for brevity. It is used to check for the
> mwait feature flag. The same can be done with a subsequent
> check for clflsh and save us a second per-cpu pointer
> dereference.
>
> Signed-off-by: Frank Arnold <frank.arnold@amd.com>
> Acked-by: Borislav Petkov <borislav.petkov@amd.com>
> ---
> arch/x86/kernel/smpboot.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>

This should be using this_cpu_has()... if that's not in the tree yet we
should add it.

Creating an absolute pointer for a percpu references is a big lose.

-hpa

--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.



\
 
 \ /
  Last update: 2011-04-13 18:55    [W:0.036 / U:3.584 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site