lkml.org 
[lkml]   [2011]   [Apr]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[18/71] xfs: prevent leaking uninitialized stack memory in FSGEOMETRY_V1
    2.6.33-longterm review patch.  If anyone has any objections, please let us know.

    ------------------

    From: Dan Rosenberg <drosenberg@vsecurity.com>

    commit c4d0c3b097f7584772316ee4d64a09fe0e4ddfca upstream.

    The FSGEOMETRY_V1 ioctl (and its compat equivalent) calls out to
    xfs_fs_geometry() with a version number of 3. This code path does not
    fill in the logsunit member of the passed xfs_fsop_geom_t, leading to
    the leaking of four bytes of uninitialized stack data to potentially
    unprivileged callers.

    v2 switches to memset() to avoid future issues if structure members
    change, on suggestion of Dave Chinner.

    Signed-off-by: Dan Rosenberg <drosenberg@vsecurity.com>
    Reviewed-by: Eugene Teo <eugeneteo@kernel.org>
    Signed-off-by: Alex Elder <aelder@sgi.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    fs/xfs/xfs_fsops.c | 3 +++
    1 file changed, 3 insertions(+)

    --- a/fs/xfs/xfs_fsops.c
    +++ b/fs/xfs/xfs_fsops.c
    @@ -57,6 +57,9 @@ xfs_fs_geometry(
    xfs_fsop_geom_t *geo,
    int new_version)
    {
    +
    + memset(geo, 0, sizeof(*geo));
    +
    geo->blocksize = mp->m_sb.sb_blocksize;
    geo->rtextsize = mp->m_sb.sb_rextsize;
    geo->agblocks = mp->m_sb.sb_agblocks;



    \
     
     \ /
      Last update: 2011-04-13 18:29    [W:0.124 / U:60.392 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site