| Date | Wed, 13 Apr 2011 08:51:33 -0700 | From | Greg KH <> | Subject | [69/74] econet: Fix crash in aun_incoming(). |
| |
2.6.32-longterm review patch. If anyone has any objections, please let us know.
------------------
From: David S. Miller <davem@davemloft.net>
commit 4e085e76cbe558b79b54cbab772f61185879bc64 upstream.
Unconditional use of skb->dev won't work here, try to fetch the econet device via skb_dst()->dev instead.
Suggested by Eric Dumazet.
Reported-by: Nelson Elhage <nelhage@ksplice.com> Tested-by: Nelson Elhage <nelhage@ksplice.com> Signed-off-by: David S. Miller <davem@davemloft.net> Cc: Moritz Muehlenhoff <jmm@debian.org> [jmm: Slightly adapted for 2.6.32] Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
--- net/econet/af_econet.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
--- a/net/econet/af_econet.c +++ b/net/econet/af_econet.c @@ -843,9 +843,13 @@ static void aun_incoming(struct sk_buff { struct iphdr *ip = ip_hdr(skb); unsigned char stn = ntohl(ip->saddr) & 0xff; + struct dst_entry *dst = skb_dst(skb); + struct ec_device *edev = NULL; struct sock *sk; struct sk_buff *newskb; - struct ec_device *edev = skb->dev->ec_ptr; + + if (dst) + edev = dst->dev->ec_ptr; if (! edev) goto bad;
|