Messages in this thread |  | | Date | Wed, 13 Apr 2011 10:45:28 -0400 | From | Prarit Bhargava <> | Subject | Re: [PATCH 2/3] x86, MCE: Drop default decoding notifier |
| |
On 04/13/2011 10:39 AM, Borislav Petkov wrote: > On Wed, Apr 13, 2011 at 10:32:35AM -0400, Prarit Bhargava wrote: > >> >>>> .. right ... but we would still see nonsensical messages before the >>>> panic, which will confuse the end user. IMO, dump the messages unless >>>> it's UC. And we shouldn't print out the human readable message at all. >>>> >>>> >>> I'd still leave the "mcelog ... " line though as a hint. >>> >>> >>> >> :) >> >> There are no messages -- that's part of the problem. We're asking a >> user to do something for a message that doesn't exist ... >> > Yes and no - in the UC case you get all the MCA registers dumped in > print_mce() - and those you want to decode. In the CE case, we won't be > issuing any with the default notifier removed. I just sent you a -v2, I > think it should do what we want. >
Yup. > Or am I missing something...? > >
Nope. The follow up looks great :)
P. > Thanks. > >
|  |