[lkml]   [2011]   [Apr]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 3/4]percpu_counter: fix code for 32bit systems

    On Wed, Apr 13, 2011 at 05:53:40AM +0200, Eric Dumazet wrote:
    > Le mercredi 13 avril 2011 à 11:03 +0800, Shaohua Li a écrit :
    > > I can do this, but please give a reason. If network code is the only
    > > place requiring disable irq, why not network code do it?
    > Lot of percpu_counter users dont use full s64 range, but "unsigned long"
    > or "unsigned int". Adding a lock on 32bit arches to get the s64, then
    > truncate it is not needed.

    Yeah, it might hurt 32bit archs a bit but if 64bit becomes better I'll
    take that any day. Also, atomic64_t implementation on x86-32 seems
    pretty good and doesn't depend on irq spinlocks (which is quite
    expensive), so it shouldn't be too bad.


    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2011-04-13 06:03    [W:0.019 / U:95.308 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site