Messages in this thread | | | Date | Tue, 12 Apr 2011 20:58:42 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH]: mce: don't print "human readable" message for corrected errors |
| |
On Tue, Apr 12, 2011 at 01:44:05PM -0400, Prarit Bhargava wrote: > Don't display the "human readable" warning for correctable errors in mce. > There is no need for this information to be displayed. > > Signed-off-by: Prarit Bhargava <prarit@redhat.com>
Why not? This way you turn reporting of _ALL_ correctable MCEs completely off and some users would actually like to run them through mcelog on Intel.
> > diff --git a/arch/x86/kernel/cpu/mcheck/mce.c b/arch/x86/kernel/cpu/mcheck/mce.c > index 450a366..8024013 100644 > --- a/arch/x86/kernel/cpu/mcheck/mce.c > +++ b/arch/x86/kernel/cpu/mcheck/mce.c > @@ -100,10 +100,16 @@ ATOMIC_NOTIFIER_HEAD(x86_mce_decoder_chain); > EXPORT_SYMBOL_GPL(x86_mce_decoder_chain); > > static int default_decode_mce(struct notifier_block *nb, unsigned long val, > - void *data) > + void *data) > { > - pr_emerg(HW_ERR "No human readable MCE decoding support on this CPU type.\n"); > - pr_emerg(HW_ERR "Run the message through 'mcelog --ascii' to decode.\n"); > + struct mce *m = (struct mce *)data; > + > + if (m->status & MCI_STATUS_UC) { > + pr_emerg(HW_ERR "No human readable MCE decoding support " > + "on this CPU type.\n"); > + pr_emerg(HW_ERR "Run the message through 'mcelog --ascii' " > + "to decode.\n"); > + } > > return NOTIFY_STOP; > } > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/
-- Regards/Gruss, Boris.
| |