lkml.org 
[lkml]   [2011]   [Apr]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/4]percpu_counter: use correct API
On Tue, Apr 12, 2011 at 04:04:01PM +0800, Shaohua Li wrote:
> percpu_counter_sum_positive never returns negative, since there
> is a negative check, I changed it to percpu_counter_sum.
>
> Signed-off-by: Shaohua Li <shaohua.li@intel.com>
>
> ---
> fs/ext4/balloc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux/fs/ext4/balloc.c
> ===================================================================
> --- linux.orig/fs/ext4/balloc.c 2011-04-12 15:48:42.000000000 +0800
> +++ linux/fs/ext4/balloc.c 2011-04-12 15:48:50.000000000 +0800
> @@ -506,7 +506,7 @@ static int ext4_has_free_blocks(struct e
> if (free_blocks - (nblocks + root_blocks + dirty_blocks) <
> EXT4_FREEBLOCKS_WATERMARK) {
> free_blocks = percpu_counter_sum_positive(fbc);
> - dirty_blocks = percpu_counter_sum_positive(dbc);
> + dirty_blocks = percpu_counter_sum(dbc);
> if (dirty_blocks < 0) {
> printk(KERN_CRIT "Dirty block accounting "
> "went wrong %lld\n",

The right thing to do would be removing if (dirty_blocks < 0) and keep
using _positive. perpcu_counter_sum() may return a negative number
spuriously (that's the whole point of _positive functions) and may
trigger the critial error path when nothing is really wrong.

Thanks.

--
tejun


\
 
 \ /
  Last update: 2011-04-12 20:55    [W:0.198 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site