lkml.org 
[lkml]   [2011]   [Apr]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH 3/3] reuse __free_pages_exact() in __alloc_pages_exact()
    From
    Date

    Michal Nazarewicz noticed that __alloc_pages_exact()'s
    __free_page() loop was really close to something he was
    using in one of his patches. That made me realize that
    it was actually very similar to __free_pages_exact().

    This uses __free_pages_exact() in place of the loop
    that we had in __alloc_pages_exact(). Since we had to
    change the temporary variables around anyway, I gave
    them some better names to hopefully address some other
    review comments.

    ---

    linux-2.6.git-dave/mm/page_alloc.c | 9 +++------
    1 file changed, 3 insertions(+), 6 deletions(-)

    diff -puN mm/page_alloc.c~reuse-free-exact mm/page_alloc.c
    --- linux-2.6.git/mm/page_alloc.c~reuse-free-exact 2011-04-11 15:01:17.701822598 -0700
    +++ linux-2.6.git-dave/mm/page_alloc.c 2011-04-11 15:01:17.713822594 -0700
    @@ -2338,14 +2338,11 @@ struct page *__alloc_pages_exact(gfp_t g

    page = alloc_pages(gfp_mask, order);
    if (page) {
    - struct page *alloc_end = page + (1 << order);
    - struct page *used = page + nr_pages;
    + struct page *unused_start = page + nr_pages;
    + int nr_unused = (1 << order) - nr_pages;

    split_page(page, order);
    - while (used < alloc_end) {
    - __free_page(used);
    - used++;
    - }
    + __free_pages_exact(unused_start, nr_unused);
    }

    return page;
    _

    \
     
     \ /
      Last update: 2011-04-12 00:07    [W:0.023 / U:0.860 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site