lkml.org 
[lkml]   [2011]   [Apr]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] fsldma: fix build warning caused by of_platform_device changes
On Thu, Apr 07, 2011 at 10:33:03AM -0700, Ira W. Snyder wrote:
> Commit 000061245a6797d542854106463b6b20fbdcb12e forgot to convert the
> type of structure passed into platform_device_register() when it was
> converted from of_platform_device_register. Fix it.
>
> Signed-off-by: Ira W. Snyder <iws@ovro.caltech.edu>
> Cc: Grant Likely <grant.likely@secretlab.ca>
> Cc: Dan Williams <dan.j.williams@intel.com>

Applied thanks.

One comment however; when quoting sha1 commit id's, please also quote
the title of the patch. Very few people I know can remember off the
top of their head the commit names that goes with a sha1 id. :-)

g.

> ---
> drivers/dma/fsldma.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/dma/fsldma.c b/drivers/dma/fsldma.c
> index 6b39675..8a78154 100644
> --- a/drivers/dma/fsldma.c
> +++ b/drivers/dma/fsldma.c
> @@ -1448,7 +1448,7 @@ static const struct of_device_id fsldma_of_ids[] = {
> {}
> };
>
> -static struct of_platform_driver fsldma_of_driver = {
> +static struct platform_driver fsldma_of_driver = {
> .driver = {
> .name = "fsl-elo-dma",
> .owner = THIS_MODULE,
> --
> 1.7.3.4
>


\
 
 \ /
  Last update: 2011-04-11 08:39    [W:0.040 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site