Messages in this thread | | | Date | Fri, 1 Apr 2011 12:24:31 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH -tip v3 3/6] perf branch trace: print pid and command |
| |
Em Fri, Apr 01, 2011 at 05:15:17PM +0200, Peter Zijlstra escreveu: > On Fri, 2011-04-01 at 17:13 +0200, Frederic Weisbecker wrote: > > On Mon, Mar 28, 2011 at 08:31:23AM -0600, David Ahern wrote: > > > On 03/28/11 04:34, Akihiro Nagai wrote: > > > >> from is sample->ip? to is sample->addr? In the above example > > > >> 0x39d3015260 is the value from sample->addr, 1526f is sample->ip which > > > >> resolves to _dl_next_ld_env_entry from /lib64/ld-2.13.so. > > > > Yes. > > > > In this example, resolved address is only sample->ip (branch from). > > > > We need the resolved address of sample->addr (branch to) too, because > > > > both of them are addresses of execution code. > > > > > > Ok, now I understand. In that case add conversion of sample->addr to > > > symbols to perf-script. > > > > I agree that we should rather use perf script for branch dumps. > > Sorry Akihiro, I think we suggested you to create this dedicated > > perf branch by the past. But then perf script became the vanilla dump > > tool in the middle and it seems more suitable today. > > > > We can still create a perf branch later in order to produce some more > > advanced post-processing tools. But for sample dumps perf script (which starts > > to show itself as a misnomer BTW) seems to be the right place. > > Why do something with snakes if its perfectly possible to do in C ?
He is not meaning using python, hence the "misnomer" comment.
- Arnaldo
| |