Messages in this thread | | | Date | Wed, 09 Mar 2011 17:29:42 -0800 | From | Darren Hart <> | Subject | Re: [PATCH trace-cmd 3/3] Revert "trace-cmd: Use conditional assignment of CC and AR" |
| |
On 03/09/2011 05:28 PM, Steven Rostedt wrote: > On Wed, 2011-03-09 at 20:21 -0500, Steven Rostedt wrote: >> On Wed, 2011-03-09 at 15:58 -0800, David Sharp wrote: >>> This reverts commit 6c696cec3f264a9399241b6e648f58bc97117d49. >>> >>> Make has default values CC and AR of 'cc' and 'ar' respectively. This means >>> that "CC ?= anything" will never have effect, because CC is always already set. >>> Because of this, 6c696cec makes setting CROSS_COMPILE from the command line or >>> environment useless. >> >> Darren, can you verify this, as you were the one to make the original >> change. I never had to cross compile it, I always did it natively. > > OK, I just proved that David is correct, with the following make file: > > --- > CC ?= foo > AR ?= bar > all: > echo what is $(CC) $(AR)
> --- > > $ make > what is cc ar > > > Darren, can you just give an Acked-by anyway. I hate to apply a revert > of your patch without you doing so.
I really thought I tested that - clearly not :/ Sorry about that. Please see my response to David for an alternate proposal.
-- Darren
> > Thanks, > > -- Steve > >
-- Darren Hart Intel Open Source Technology Center Yocto Project - Linux Kernel
| |