Messages in this thread | | | Subject | Re: [PATCH trace-cmd 3/3] Revert "trace-cmd: Use conditional assignment of CC and AR" | From | Steven Rostedt <> | Date | Wed, 09 Mar 2011 20:21:42 -0500 |
| |
On Wed, 2011-03-09 at 15:58 -0800, David Sharp wrote: > This reverts commit 6c696cec3f264a9399241b6e648f58bc97117d49. > > Make has default values CC and AR of 'cc' and 'ar' respectively. This means > that "CC ?= anything" will never have effect, because CC is always already set. > Because of this, 6c696cec makes setting CROSS_COMPILE from the command line or > environment useless.
Darren, can you verify this, as you were the one to make the original change. I never had to cross compile it, I always did it natively.
David, Thanks! I'll go ahead and apply patch 1 and 2, and I'll wait for a reply from Darren for this patch.
-- Steve
> > Signed-off-by: David Sharp <dhsharp@google.com> > Cc: Darren Hart <dvhart@linux.intel.com> > Cc: Steven Rostedt <rostedt@goodmis.org> > --- > Makefile | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Makefile b/Makefile > index 169fcbc..fa37df5 100644 > --- a/Makefile > +++ b/Makefile > @@ -13,8 +13,8 @@ FILE_VERSION = 6 > > MAKEFLAGS += --no-print-directory > > -CC ?= $(CROSS_COMPILE)gcc > -AR ?= $(CROSS_COMPILE)ar > +CC = $(CROSS_COMPILE)gcc > +AR = $(CROSS_COMPILE)ar > EXT = -std=gnu99 > INSTALL = install >
| |