Messages in this thread | | | Date | Wed, 9 Mar 2011 08:26:17 +0100 | From | Jens Axboe <> | Subject | Re: blk-throttle: Use blk_plug in throttle code (Was: Re: [PATCH 05/10] block: remove per-queue plugging) |
| |
On 2011-03-08 23:10, Vivek Goyal wrote: > On Tue, Mar 08, 2011 at 01:24:01PM +0100, Jens Axboe wrote: >> On 2011-03-04 05:00, Vivek Goyal wrote: >>> On Sat, Jan 22, 2011 at 01:17:24AM +0000, Jens Axboe wrote: >>> >>> [..] >>>> mm/page-writeback.c | 2 +- >>>> mm/readahead.c | 12 --- >>>> mm/shmem.c | 1 - >>>> mm/swap_state.c | 5 +- >>>> mm/swapfile.c | 37 -------- >>>> mm/vmscan.c | 2 +- >>>> 118 files changed, 153 insertions(+), 1248 deletions(-) >>> >>> block/blk-throttle.c also uses blk_unplug(). We need to get rid of that >>> also. >> >> Done. > > Thanks Jens. Looking at the usage of blk_plug, i think it makes sense to > make use of it in throttle dispatch also. Here is the patch.
Yep, it definitely does. Thanks, I'll apply this.
-- Jens Axboe
| |