Messages in this thread | | | Subject | Re: [RFC][PATCH 4/6] arm, mm: Convert arm to generic tlb | From | Peter Zijlstra <> | Date | Wed, 09 Mar 2011 16:19:24 +0100 |
| |
On Wed, 2011-03-09 at 15:16 +0000, Catalin Marinas wrote: > Hi Peter, > > On 2 March 2011 17:59, Peter Zijlstra <a.p.zijlstra@chello.nl> wrote: > > --- linux-2.6.orig/arch/arm/include/asm/tlb.h > > +++ linux-2.6/arch/arm/include/asm/tlb.h > [...] > > +__pte_free_tlb(struct mmu_gather *tlb, pgtable_t pte, unsigned long addr) > > { > > pgtable_page_dtor(pte); > > - tlb_add_flush(tlb, addr); > > tlb_remove_page(tlb, pte); > > } > > I think we still need a tlb_track_range() call here. On the path to > pte_free_tlb() (for example shift_arg_pages ... free_pte_range) there > doesn't seem to be any code setting the tlb->start/end range. Did I > miss anything?
Patch 3 included:
-#define pte_free_tlb(tlb, ptep, address) \ - do { \ - tlb->need_flush = 1; \ - __pte_free_tlb(tlb, ptep, address); \ +#define pte_free_tlb(tlb, ptep, address) \ + do { \ + tlb->need_flush = 1; \ + tlb_track_range(tlb, address, pmd_addr_end(address, TASK_SIZE));\ + __pte_free_tlb(tlb, ptep, address); \ } while (0)
Also, I posted a new version of this series here:
https://lkml.org/lkml/2011/3/7/308
| |