lkml.org 
[lkml]   [2011]   [Mar]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/2] hpsa: export resettable_on_kexec host attribute
    On Wed, Mar 09, 2011 at 02:33:39PM +0800, Américo Wang wrote:
    > On Tue, Mar 08, 2011 at 05:10:03PM -0600, Stephen M. Cameron wrote:
    > >From: Stephen M. Cameron <scameron@beardog.cce.hp.com>
    > >
    > >This attribute, requested by Redhat, allows kexec-tools to know
    > >whether the controller can honor the reset_devices kernel parameter
    > >and actually reset the controller. For kdump to work properly it
    > >is necessary that the reset_devices parameter be honored. This
    > >attribute enables kexec-tools to warn the user if they attempt to
    > >designate a non-resettable controller as the dump device.
    > >
    > >Signed-off-by: Stephen M. Cameron <scameron@beardog.cce.hp.com>
    >
    > Reviewed-by: WANG Cong <xiyou.wangcong@gmail.com>
    >
    > Maybe we should docment this sysfs attribute somewhere?

    Yes, thanks.

    Perhaps in Documentation/ABI/testing/sysfs-bus-scsi-devices-hpsa
    (which doesn't exist) and/or in Documentation/scsi/hpsa.txt (which does exist, and
    is where other hpsa specific sysfs attributes are documented.) Probably so
    as not to duplicate things, the latter. Or maybe what documentation of
    sysfs things that is currently in hpsa.txt should be moved to Documentation/ABI/...
    and a reference to it put in hpsa.txt?

    -- steve

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2011-03-09 15:39    [W:0.035 / U:94.496 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site