Messages in this thread | | | Date | Wed, 9 Mar 2011 11:06:10 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH 1/2] perf,top: fix events overflow in top command |
| |
Em Wed, Mar 09, 2011 at 10:59:25AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Mon, Mar 07, 2011 at 09:13:40PM +0100, Jiri Olsa escreveu: > > The snprintf function returns number of printed characters even > > if it cross the size parameter. So passing enough events via '-e' > > parameter will cause segmentation fault. > > > > It's reproduced by following command: > > > > perf top -e `perf list | grep Tracepoint | awk -F'[' '\ > > {gsub(/[[:space:]]+/,"",$1);array[FNR]=$1}END{outputs=array[1];\ > > for (i=2;i<=FNR;i++){ outputs=outputs "," array[i];};print outputs}'` > > > > Attached patch is adding SNPRINTF macro that provides the > > overflow check and returns actuall number of printed characters. > > Good catch, applying to perf/urgent.
Tried but it doesn't apply nor can I reproduce the overflow (albeit granted the long line of events is annoying).
So I'm applying both patches to perf/core instead.
- Arnaldo
| |